Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting: contract multi-line expressions #361

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Jul 19, 2019

Used Black to contract expression spanning more than one line into a single line, if it fits into the 119 line-length limit. If the expression is a collection of comma-separated items, the trailing comma has been removed. No other changes to the code has been made.

Expressions, whose line count could be reduced, but would need changing the indentation style, have not been touched. That will be subject of another pull request.

This is a part of an ultimate formatting fix so Black can be run automatically for every commit and pull request. #335

@Glutexo Glutexo self-assigned this Jul 19, 2019
@Glutexo Glutexo changed the title Contract multi-line expressions Formatting: contract multi-line expressions Jul 19, 2019
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 22, 2019

Contracted one more line consisting only of a string split to multiple lines.

@Glutexo Glutexo mentioned this pull request Jul 22, 2019
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 24, 2019

This pull request has been approved. Can we merge it?

Used Black to contract expression spanning more than one line into a
single line, if it fits into the 119 line-length limit. If the
expression is a collection of comma-separated items, the trailing comma
has been removed. No other changes to the code has been made.

Expressions, whose line count could be reduced, but would need changing
the indentation style, have not been touched.
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 25, 2019

Rebased, mergeable again.

@Glutexo Glutexo added the cleanup Small changes not affecting behavior label Jul 25, 2019
@dehort dehort merged commit ebf25c1 into RedHatInsights:master Jul 25, 2019
@Glutexo Glutexo deleted the black_short_lines branch July 26, 2019 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Small changes not affecting behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants