Formatting: Add Black as a development dependency #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegorafrh
approved these changes
Jul 23, 2019
Glutexo
changed the title
|
This pull request has been approved. Can we merge it? |
|
Rebased to rebuild the lock file. |
Added Black to the development packages list. It is added with the specific version, so it is installed even though it is a pre-release. Created a pyproject.toml configuration file for it.
|
Rebased to rebuild the lock file again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Black to the development packages list. It is added with the specific version, so it is installed even though it is a pre-release. Created a pyproject.toml configuration file for it. It is the only configuration format Black understands. Unfortunately Flake8 doesn’t support this configuration file yet, so .flake8 remains and the line length value is duplicated.
I configured it to be compatible only with Python 3.6, which we use. Line length is extended to 119 from a previous agreement. The suggested safe option is not present as it is a default.
This is a complement to pre-commit hooks (#331) that allows to run all the code cleaning stuff (#335) manually too.