Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization: Host serialization cleanup #529

Closed

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Nov 22, 2019

Change the (de)serialization logic, so the serialization expects that the object is valid. All default values and validation happens now upon deserialization. That concentrates the logic into a single place.

Rebased version of #328.

@Glutexo Glutexo self-assigned this Nov 22, 2019
@Glutexo Glutexo changed the title Trust the deserialized values Serialization: Host serialization cleanup Nov 22, 2019
Change the (de)serialization logic, so the serialization expects that
the object is valid. All default values and validation happens now upon
deserialization. That concentrates the logic into a single place.
@Glutexo
Copy link
Collaborator Author

Glutexo commented Nov 22, 2019

Rebased.

Copy link
Member

@jharting jharting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like style check is failing for this PR

@jharting jharting added the conflict needs to be resolved and rebased label Mar 25, 2020
@Glutexo
Copy link
Collaborator Author

Glutexo commented Aug 10, 2020

This is tracked in RHCLOUD-3521. Closing to clean up the queue.

@Glutexo Glutexo closed this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict needs to be resolved and rebased
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants