Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require permissions for create integration #1273

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CodyWMitchell
Copy link
Contributor

Description

Conditionally display items in the dropdown based on the users permissions.

  • If the user has sources::write or sources:*:write permissions, display both types of integrations and the option to add cloud integrations.
  • If the user has integrations::write, integrations:*:write, or integrations:endpoints:write permissions, display both types of integrations and the option to add 3rd-party integrations.
  • If user has neither sets of permissions, then the dropdown is disabled.

RHCLOUD-36321


Screenshots

Both

image

Only sources permissions

image

Only integrations permissions

image

Neither permissions

image


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@fhlavac
Copy link
Contributor

fhlavac commented Nov 27, 2024

@CodyWMitchell just curious, does it also cover creating the integration from the empty state in a scenario when the user has only read permissions?

image

@karelhala
Copy link
Contributor

@fhlavac good point! @CodyWMitchell btw you should filter the tiles on empty state as well.

@CodyWMitchell
Copy link
Contributor Author

image
image
image

@fhlavac Good catch! Now the tiles in the empty state should also being showing conditionally based on the permissions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants