[GEN-1612] Use 16.6-consortium for CRC 3.1 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu17
changed the title
|
thomasyu888
reviewed
Nov 15, 2024
thomasyu888
reviewed
Nov 15, 2024
| @@ -521,6 +521,7 @@ class BpcProjectRunner(metaclass=ABCMeta): | |||
| _SPONSORED_PROJECT = "" | |||
| # Redcap codes to cbioportal mapping synid and form key is in | |||
| # version 38, 42 were last stable version(s) | |||
| # NOTE: Should be pointed towards latest version of table | |||
There was a problem hiding this comment.
There will be a new mapping version, did we want to wait until that is in to update both at the same time?
There was a problem hiding this comment.
Yes this PR can be in place here.
There was a problem hiding this comment.
Are we waiting on MSK cBioPortal team to share the newer mapping file?
|
🎉 All dependencies have been resolved ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
_MG_RELEASE_SYNIDto use 16.6-consortium for CRC 3.1 release._REDCAP_TO_CBIOMAPPING_SYNIDTesting:
Depends on #143