SWC-7194 #5589
Merged
SWC-7194 #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay-hodgson
commented
Nov 25, 2024
| @@ -352,10 +352,7 @@ public void onError(Throwable caught) { | |||
| headerWidget.configure(); | |||
| if (caught instanceof NotFoundException) { | |||
| show404(); | |||
| } else if ( | |||
| caught instanceof ForbiddenException && | |||
| authenticationController.isLoggedIn() | |||
There was a problem hiding this comment.
Previously, if anonymous it would call StuAlert handleException() which passed in null for the entity ID (and version). Now, we always call show403(entityId, versionNumber), but only show the open invitations if you are logged in (see show403() in this class).
nickgros
reviewed
Nov 25, 2024
| if (entityId != null) { | ||
| synAlert.show403(entityId, versionNumber); | ||
| } | ||
| synAlert.show403(entityId, versionNumber); |
There was a problem hiding this comment.
does this work ok if the entity ID is nonsense, like if the place is Synapse:notASynId? Just wondering if the null check is relevant to parsing the place token
There was a problem hiding this comment.
Works with an invalid synapse ID place token (we do attempt to get the DOI information, which results in a 400, but this does not impact the UI).
nickgros
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.