Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Filter::getTimePeriodValues() function (skip null values) #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pastakhov
Copy link
Contributor

  • It returns "0-9" in possibleFilterValues when the first value is null.
  • Also I don't think there is sense to call $timePeriod = $this->timePeriod() every loop.

* It returns "0-9" in possibleFilterValues when the first value is null.
* Also I don't think there is sense to call
    $timePeriod = $this->timePeriod() every loop.
@codecov-commenter
Copy link

Codecov Report

Merging #49 (b1922a1) into master (c517061) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
- Coverage     68.98%   68.96%   -0.02%     
- Complexity      740      741       +1     
============================================
  Files            36       36              
  Lines          2086     2088       +2     
============================================
+ Hits           1439     1440       +1     
- Misses          647      648       +1     
Impacted Files Coverage Δ
includes/Filter.php 81.00% <75.00%> (-0.32%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gesinn-it-gea
Copy link
Member

@pastakhov please always create an issue before a PR so that it's easier to reference or discuss changes beforehand.

@gesinn-it-wam
Copy link
Contributor

Did you consider writing a failing test before fixing the issue? (Something along the lines of filters.json in a separate test file date-filters.json) Having a problematic setting would make code review much easier! (Not to mention the many other benefits of having tests...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants