Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check links on deployments, as well as daily via cron #125

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mlocher
Copy link
Member

@mlocher mlocher commented Jan 17, 2024

No description provided.

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fusejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:12pm
spacex-fuse ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 4:12pm

@mxstbr
Copy link
Contributor

mxstbr commented Jan 19, 2024

CleanShot 2024-01-19 at 08 13 05@2x

It's looking at the SpaceX example instead of the docs deployment.

@mlocher
Copy link
Member Author

mlocher commented Jan 19, 2024

It's looking at the SpaceX example instead of the docs deployment.

It takes the deployment URL that Vercel reports via the GitHub Deployments API and looks at that for PRs the main branch.

For the cron based runs it looks at the default URL configured in the environment variable.

If we have multiple Vercel apps connected to this repo, it might look at wrong deployments in some cases 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants