reshade: Summarise code-section of ReshadeUniform::{PingPongUniform,RandomUniform}()
#1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To keep PR clean, moved extra observations comment to a GitHub Gist here. |
|
I will be honest, I find this much harder to read and rationalise about |
|
Hi @Joshua-Ashton, thanks for updating! Happy to make any changes! 😄 Sure thing! Is it the changeset / PR, or the condensed code, or the API calling the static free-function, or any other things, which is harder to read or rationalise about? Should the previous repeating code not be condensed at all? There are quite a few lines of code which are repeating in this changeset, but condensing the code too much will make it harder to rationalise I agree, so looking for a happy medium with your guidance. 😄 |
tcoyvwac
force-pushed
the
fix/reshade-condense-functions-with-lambdas-free-functions
branch
4 times, most recently
from
2b281b4
to
7f169cb
Compare
annotationAttributes for-loop check now handles an array of attributes
* processAttributes: local and parameter variable scoping + variable's domain coupling (by using closures) reduced. * reshade: inlined type_ternary parameter into IIFE
tcoyvwac
force-pushed
the
fix/reshade-condense-functions-with-lambdas-free-functions
branch
from
7f169cb
to
f4bf38e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! 😄
Following the positive response of PR:#998, and a followup to PR:#1260, this PR condenses and summaries some common code-fragments in
ReshadeUniform::{PingPongUniform,RandomUniform}'s constructors -().As usual, I kept the commit history for code-review purposes and ease however please feel free when this PR is complete, to condense / squash everything into one commit for git-history reasons if you like!
Please note:
There are additional points and questions discovered and raised in this PR. They are listed in a further comment ahead here.
Of course, happy to answer any questions and do my best explaining the design of the changeset.
Thanks and hope this helps! 😄