Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-1569 Prepare for null safety: fix lints and implicit casts #366

Merged
merged 31 commits into from
Aug 22, 2023
Merged

FED-1569 Prepare for null safety: fix lints and implicit casts #366

merged 31 commits into from
Aug 22, 2023

Commits on Aug 9, 2023

  1. Upgrade lints to workiva_analysis_options v2.recommended

    @greglittlefield-wf
    greglittlefield-wf committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    e452d16 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. dart fix --apply --code=unnecessary_new

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1446d0b View commit details
    Browse the repository at this point in the history

  2. dart fix --apply --code=unnecessary_const

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1e322c2 View commit details
    Browse the repository at this point in the history

  3. dart fix --apply --code=prefer_single_quotes

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    acc03f1 View commit details
    Browse the repository at this point in the history

  4. dart fix --apply --code=deprecated_colon_for_default_value

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5d2793d View commit details
    Browse the repository at this point in the history

  5. dart fix --apply --code=annotate_overrides

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    d19f23d View commit details
    Browse the repository at this point in the history

  6. dart fix --apply --code=prefer_final_in_for_each

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    bcad3b1 View commit details
    Browse the repository at this point in the history

  7. dart fix --apply --code=omit_local_variable_types,prefer_final_locals

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8d1a829 View commit details
    Browse the repository at this point in the history

  8. Fix missing inferred generics

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    46a38d2 View commit details
    Browse the repository at this point in the history

  9. dart fix --apply --code=use_function_type_syntax_for_parameters,pref… 

    …er_generic_function_type_aliases
    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    17b30cc View commit details
    Browse the repository at this point in the history

  10. Fix more typedefs

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    b79d3eb View commit details
    Browse the repository at this point in the history

  11. dart fix --apply --code=unnecessary_this

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    6490a9c View commit details
    Browse the repository at this point in the history

  12. dart fix --apply --code=unnecessary_brace_in_string_interps

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1b5f972 View commit details
    Browse the repository at this point in the history

  13. dart fix --apply --code=unnecessary_parenthesis

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    2948941 View commit details
    Browse the repository at this point in the history

  14. Disable some more lints

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    911c914 View commit details
    Browse the repository at this point in the history

  15. Remove some unnecessary function parameter types, link to linter issue

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    70429ac View commit details
    Browse the repository at this point in the history

  16. Ignore lints that could change behavior or break public API if fixed

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ae1914e View commit details
    Browse the repository at this point in the history

  17. dart fix --apply --code=unused_import

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    8b83f89 View commit details
    Browse the repository at this point in the history

  18. dart fix --apply --code=unnecessary_import

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    ae87897 View commit details
    Browse the repository at this point in the history

  19. Fix miscellaneous remaining lints (dart fix --apply)

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    82c5d9e View commit details
    Browse the repository at this point in the history

  20. Ignore componentZone usage warnings

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    a7beb88 View commit details
    Browse the repository at this point in the history

  21. Remove unused code

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1a6d534 View commit details
    Browse the repository at this point in the history

  22. Fix warnings by hand

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    9949639 View commit details
    Browse the repository at this point in the history

  23. Fix comment references and links - all credit to @aaronlademann-wf

    @aaronlademann-wf @greglittlefield-wf
    aaronlademann-wf authored and greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    5344c86 View commit details
    Browse the repository at this point in the history

  24. Fix implicit casts, clean up variable types and final

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e1e3f7f View commit details
    Browse the repository at this point in the history

  25. Format

    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    35297ff View commit details
    Browse the repository at this point in the history

  26. Remove return types on overrides so they can be inferred 

    The fewer explicit types we have, the fewer need to be updated
during the transition to null safety

Done via replacement of `(@OverRide\n  )(?![gs]et )([^(=\n]+ )([^(=\n]+\()` with `$1/$3`
    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    94d3507 View commit details
    Browse the repository at this point in the history

  27. Remove return types on overridden getters so they can be inferred 

    The fewer explicit types we have, the fewer need to be updated
during the transition to null safety

Done via replacement of `(@OverRide\n  )([^(=\n]+ )(get [^(=\n]+=)` with `$1/$3`
    @greglittlefield-wf
    greglittlefield-wf committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    cf5e31a View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Format

    @greglittlefield-wf
    greglittlefield-wf committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b778dcd View commit details
    Browse the repository at this point in the history

  2. Disable Dart 3 CI run for now

    @greglittlefield-wf
    greglittlefield-wf committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    920f9b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Add comment LHS-typed function declaration

    @greglittlefield-wf
    greglittlefield-wf committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    60aec37 View commit details
    Browse the repository at this point in the history