Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-1727 Remove the rest of the deprecated APIs for v7 #375

Merged
merged 8 commits into from
Oct 20, 2023

Conversation

greglittlefield-wf
Copy link
Collaborator

@greglittlefield-wf greglittlefield-wf commented Oct 6, 2023

Dependent PR

This PR is dependent on #373. I've made this PR into the null safety branch so that this is a clean diff, and we'll want to merge that PR first before this one.

Motivation

There are some APIs we've planned on removing in 7.0.0, and it's time to remove them.

Some APIs have already been removed in the v7_wip branch, and this PR should remove the rest of them.

Notably, there were quite a few APIs that aren't being removed outright, but instead are being made private.

Solution

  • lib/react_client/react_interop.dart
    • Remove unused, deprecated APIs
      • JsPropValidator
      • ReactElementStore
      • React.createFactory
    • Make deprecated APIs private (mostly moved to a new lib/src/react_client/internal_react_interop.dart):
      • InteropContextValue
      • ReactDartContextInternal
      • markChildValidated
      • markChildrenValidated
      • createReactDartComponentClass
      • createReactDartComponentClass2
      • ReactDartInteropStatics
      • ComponentStatics
      • ComponentStatics2
      • JsComponentConfig
      • JsComponentConfig2
  • Remove deprecated APIs in other libraries
    • SyntheticEvent members persist and isPersistent
    • memo

Testing

We'll do another semver audit of API changes from other PRs when we go to merge v7_wip, so no additional testing is needed at this time.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf greglittlefield-wf changed the title Remove the rest of the depredated APIs for v7 Remove the rest of the deprecated APIs for v7 Oct 6, 2023
@rmconsole6-wk rmconsole6-wk changed the title Remove the rest of the deprecated APIs for v7 FED-1727 Remove the rest of the depredated APIs for v7 Oct 9, 2023
@greglittlefield-wf greglittlefield-wf requested review from a team and brianphillips-wk and removed request for a team October 10, 2023 18:06
@greglittlefield-wf greglittlefield-wf changed the title FED-1727 Remove the rest of the depredated APIs for v7 FED-1727 Remove the rest of the deprecated APIs for v7 Oct 10, 2023
@brianphillips-wk brianphillips-wk requested review from a team and joebingham-wk and removed request for brianphillips-wk, a team and joebingham-wk October 11, 2023 17:28
@greglittlefield-wf greglittlefield-wf requested review from a team, brianphillips-wk and aaronlademann-wf and removed request for a team and brianphillips-wk October 12, 2023 00:17
@greglittlefield-wf greglittlefield-wf changed the base branch from null-safety-manual-2 to v7_wip October 16, 2023 17:03
@greglittlefield-wf greglittlefield-wf removed the Hold Hold merges label Oct 16, 2023
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aaronlademann-wf
Copy link
Collaborator

+10

  • Changes here, and the changelog itself match up with the semver report
  • CI Passing

@greglittlefield-wf
Copy link
Collaborator Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf merged commit 440c5e3 into v7_wip Oct 20, 2023
4 of 5 checks passed
@rmconsole2-wf rmconsole2-wf deleted the v7-removals branch October 20, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants