Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Allow default cluster_type #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dtjm
Copy link

@dtjm dtjm commented Nov 2, 2017

This is a just a proof-of-concept. I welcome feedback on whether this is an idea you would accept, and if so, how to prepare the PR to your standards.

If cluster_type is not specified on the command line, and only 1
cluster_type is configured, then the command will use that cluster_type.

The purpose is to simplify the command-line invocation when you always
have only 1 cluster type.

Thanks!

If cluster_type is not specified on the command line, and only 1
cluster_type is configured, then the command will use that cluster_type.

The purpose is to simplify the command-line invocation when you always
have only 1 cluster type.
Copy link
Contributor

@Baisang Baisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this!

The only issue I see is that if there is >1 cluster_type, but the user does not specify one, we need to surface that issue to the user in a clean way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants