Migrate to ESM #15
Open
Migrate to ESM #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've recently migrated Chrome DevTools to ESM, and have traditionally been using acorn as the parser for various features including the prettifier. In the context of https://crbug.com/1084349 we are looking into including private fields support in Chrome DevTools via this plugin, and in order to make that easier with our build system, I've added support for ESM output here in addition to the CJS output. Similar change to acornjs/acorn-private-methods#4.
bmeurer
approved these changes
Aug 19, 2020
|
Hi, does this PR look okay? |
adrianheine
reviewed
Oct 18, 2020
Co-authored-by: Adrian Heine né Lang <[email protected]>
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've recently migrated Chrome DevTools to ESM, and have traditionally
been using acorn as the parser for various features including the
prettifier. In the context of https://crbug.com/1084349 we are looking
into including private fields support in Chrome DevTools via this
plugin, and in order to make that easier with our build system, I've
added support for ESM output here in addition to the CJS output.
Similar change to
acornjs/acorn-private-methods#4.