[Windows] Unpin Postgres allowing latest v14 version

[lawrencegripper]

Description

New tool, Bug fixing, or Improvement?

• Version update

Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.

• Currently patch version of postgres is pinned on Windows. This removes that pin to allow the latest minor version of v14 to be installed.

For new tools, please provide total size and installation time.

Related issue:

• [windows] Pin PostgreSQL and Update LLVM #10014
• [windows] PostgreSQL pinned to vulnerable version on Windows #10871

Check list

• Related issue / work item is attached
• Tests are written (if applicable)
• Documentation is updated (if applicable)
• Changes are tested and related VM images are successfully generated

[lawrencegripper]

Hitting this when running the CI. Having a look at debugging now.

==> azure-arm.image: Provisioning with powershell script: /home/runner/work/runner-images-ci/runner-images-ci/images/windows/templates/../scripts/build/Install-PostgreSQL.ps1
    azure-arm.image: Downloading package from https://get.enterprisedb.com/postgresql/postgresql-14.15-1-windows-x64.exe to C:\Users\packer\AppData\Local\Temp\postgresql-14.15-1-windows-x64.exe...
    azure-arm.image: Package downloaded in 1.27 seconds
    azure-arm.image: Signature for C:\Users\packer\AppData\Local\Temp\postgresql-14.15-1-windows-x64.exe is valid
    azure-arm.image: Starting Install ...
    azure-arm.image: Installation process returned unexpected exit code: 1
    azure-arm.image: Time elapsed: 141.61 seconds

[lawrencegripper]

With a local Windows box I can reproduce this error.

I get:

There has been an error. Error running ...\getlocales.exe : child killed: unknown signal

Searching this maps to the issue seen here

https://stackoverflow.com/questions/71790488/postgresql-error-running-c-getlocales-exe-child-killed-unknown-signal

Running postgres.exe --help shows that --install-runtimes 0 skips installing the necessary MSVC Redistributable which the installer needs.

Testing locally, with that param removed the installation goes ahead

I think this worked with previous versions as they used aka.ms/vs/17/release/vc_redist.x64.exe which is installed by out Install-VisualStudio.ps1 command here:

https://github.com/lawrencegripper/runner-images/blob/181b98660dd23f8de32e6cb068d261e98b6bdad0/images/windows/templates/windows-2019.pkr.hcl#L388

https://github.com/lawrencegripper/runner-images/blob/181b98660dd23f8de32e6cb068d261e98b6bdad0/images/windows/scripts/helpers/VisualStudioHelpers.ps1#L35

As that that provisioner is invoked before postgres the MSVC Redistributable was present when we got to installing postgres.

Now that postgres needs MSVC 17 that is no longer the case.

I've removed the --install_runtimes 0 from the postgres install so it'll add MSVC 17 and in future auto add newer ones as it requires them.