Add concepts and concrete types where possible for BlockZipperJoinImpl
#1625
+63
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinTF
commented
Nov 18, 2024
| if (allBlocksWereFilled) { | ||
| blockStatus = BlockStatus::allFilled; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Here, self is swapped with this
RobinTF
commented
Nov 18, 2024
| AD_CORRECTNESS_CHECK(!lessThan_(lastProcessedElement, | ||
| std::as_const(blocks.front()).back())); | ||
| AD_CORRECTNESS_CHECK( | ||
| !lessThan_(lastProcessedElement, blocks.front().back())); |
There was a problem hiding this comment.
Here as_const is dropped. This presumably works because of recent fixes to the IdTable class.
Conformance check passed ✅No test result changes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
- Coverage 89.28% 89.28% -0.01%
==========================================
Files 374 374
Lines 35608 35613 +5
Branches 4019 4019
==========================================
+ Hits 31792 31796 +4
Misses 2520 2520
- Partials 1296 1297 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small follow-up to #1616 that narrows down types where possible to avoid having to guess which type is used.
Not quite sure if the "SameAsAny" stuff helps readability though.