Reduce amount of CartesianProductJoinLazyTest variants
#1648
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1648 +/- ##
=======================================
Coverage 89.37% 89.38%
=======================================
Files 375 375
Lines 36107 36107
Branches 4077 4077
=======================================
+ Hits 32272 32275 +3
Misses 2518 2518
+ Partials 1317 1314 -3 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the same seed to have a lot of variants using different offsets and limits, this changes the seeding to use the offset and limit to generate a seed. This allows to greatly reduce the total amount of tests (which come with a lot of overhead when running them with ctest), with hopefully only minor to no changes is robustness.