Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo exchange uses arrays #297

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Halo exchange uses arrays #297

wants to merge 9 commits into from

Conversation

FlorianDeconinck
Copy link
Contributor

Purpose

Our Halo Exchange use a pattern of memory specification at init and then at runtime passing the actual memory to be exchanged. The type of the parameters is Quantity, but truly it doesn't need such a high level concept and simple arrays would do. Moving to simple arrays would allow for DaCe orchestration to use the same code pattern.

Code changes:

  • Move runtime of halo exchange to work on arrays
  • Remove all reference to state & tracers at init time now that they are superflous

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated
  • Unit tests are added or updated for non-stencil code changes

@FlorianDeconinck FlorianDeconinck added the inactive This PR is not currently being worked on label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive This PR is not currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant