Improvement [3463] Improved Date formatter #3466
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucelwl
reviewed
Oct 30, 2024
| @@ -211,11 +212,16 @@ public static MetricNode fromThinString(String line) { | |||
| * @return string format of this. | |||
| */ | |||
| public String toFatString() { | |||
| DateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); | |||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss"); | |||
There was a problem hiding this comment.
DateTimeFormatter 应该改成静态成员变量
private static DateTimeFormatter df = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
There was a problem hiding this comment.
Done made it as private static variable
|
|
||
| LocalDateTime dateTime = LocalDateTime.ofInstant(Instant.ofEpochMilli(timestamp), ZoneId.systemDefault()); | ||
| sb.append(dateTime.format(formatter)).append("|"); | ||
|
|
There was a problem hiding this comment.
dateTime.format(formatter)改成 df.format(dataTime), 因为dateTime.format(formatter)内部就是调用的df.format(dataTime)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Improvement for date formatter
Does this pull request fix one issue?
#3463 3463
Fixes #3463 3463
Describe how you did it
Changed to DateTimeFormatter from Java
Describe how to verify it
Special notes for reviews