Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@angular/ssr): add
modulepreload
for lazy-loaded routes #28919base: main
Are you sure you want to change the base?
feat(@angular/ssr): add
modulepreload
for lazy-loaded routes #28919Changes from all commits
4cb8cf5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider: Users can do pretty weird things in the HTML like:
Technically the last
</body>
would be in the JS, not the HTML.It's a pretty extreme scenario, so I don't know that we really need to be too concerned about it. The "correct" solution is likely using a real HTML parser, but that might be worth it for this kind of edge case.
I mainly just wanted to point out this potential issue, up to you if it's worth solving. If we do choose to leave this, I would recommend at least having a comment which calls out that behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite an extreme edge case, that I feel that we should not worry about right now.