-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Angular 14.0.0 #1405
Conversation
Co-authored-by: michael faith <[email protected]>
Hi there. Any idea when we can expect the release of a new version? Would be really great so we can update to Angular 14. Thank you very much. |
There are a couple of issues that I'd like to resolve before we cut a release. I have no issue if @SamuelMarks would like to remove the version bump for this, that way at least the nightly builds will support v14. But I want to close out at least #1396 and #1394, which were regressions of the last version. I've slated some time for this week to investigate these, and if all goes to plan, we could see a release sometime next week. In the meantime, there are some NPM and Yarn workarounds you can use to migrate. Also big thanks to @SamuelMarks for taking on this work (this PR, not the issues above), it is much appreciated. |
what time will the pr be merged? |
Thinking the browserstack issues might be caused by permissions of some sort, I opened #1409 (with some other stuff I wanted to include), but that's failing too with the same issue. I'll reach out to the dev infra team to help resolve this. |
@CaerusKaru for this and future updates, would it be possible to use peer deps similar to how Angular Material does, which includes the next major version as well, to ease the update process. e.g. |
I haven't use CircleCI so not sure how it should work but there is two Errors even there is Success in the end. Both errors say this "DEPRECATION: Passing custom equality testers to MatchersUtil#equals is deprecated." I point it out here if you missed it. https://app.circleci.com/pipelines/github/angular/flex-layout/270/workflows/10db3ad6-18ef-47d8-8dee-9c25b572db2a/jobs/7792 |
any progress on this @joanllenas @CaerusKaru @SamuelMarks ? $ pnpm add @angular/flex-layout @angular/cdk
Already up-to-date
Progress: resolved 543, reused 523, downloaded 0, added 0, done
WARN Issues with peer dependencies found
.
└─┬ @angular/flex-layout
├── ✕ unmet peer @angular/cdk@^13.0.0: found 14.0.2
├── ✕ unmet peer @angular/core@^13.0.0: found 14.0.1
├── ✕ unmet peer @angular/common@^13.0.0: found 14.0.1
└── ✕ unmet peer @angular/platform-browser@^13.0.0: found 14.0.1 It is really annoying and unstable to use |
@@ -29,7 +29,7 @@ | |||
"tslib": "^2.3.0" | |||
}, | |||
"peerDependencies": { | |||
"@angular/cdk": "^13.0.0", | |||
"@angular/cdk": "^14.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon the repeated comment, I wanted to point out the specific line this was referring to
@CaerusKaru for this and future updates, would it be possible to use peer deps similar to how Angular Material does, which includes the next major version as well, to ease the update process. e.g.
^14.0.0 || ^15.0.0
(https://github.com/angular/components/blob/5816a12dfa816e3f340627fdf561658de0e8c970/packages.bzl#L4) It's not usually the case that the next major Angular or CDK versions break this library, so it's likely safe to do and would improve the DX for this interim period between angular and flex layout releases.
… enable prior major `^13.0.0 || `
…^14.0.0 || ^15.0.0'
Looks like you'll need to change the docker image used by circleci to build properly. I assume you'll be able to safely update to the latest 14.x version image: cimg/node:14.19.3 as well as the browsers image used for testing: cimg/node:14.19.3-browsers This is probably why #1409 built. It also has a few other changes in .circleci/config.yml |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Issues:
…and:
Approach: