Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kind jobs to the cloud Jenkins #6521

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Migrate kind jobs to the cloud Jenkins #6521

merged 1 commit into from
Nov 7, 2024

Conversation

KMAnju-2021
Copy link
Contributor

@KMAnju-2021 KMAnju-2021 commented Jul 9, 2024 •
edited
Loading

Signed-off-by: KMAnju-2021 [email protected]
part of: #6698

@KMAnju-2021 KMAnju-2021 marked this pull request as draft July 9, 2024 10:06
@KMAnju-2021 KMAnju-2021 requested a review from rajnkamr July 9, 2024 10:06
@rajnkamr rajnkamr added this to the Antrea v2.2 release milestone Jul 15, 2024
@KMAnju-2021 KMAnju-2021 added area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers area/test/jenkins Issue about jenkins setup code labels Jul 29, 2024
@antrea-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-ipv6-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-ipv6-only-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-ipv6-only-networkpolicy

@KMAnju-2021 KMAnju-2021 marked this pull request as ready for review September 30, 2024 10:50
@KMAnju-2021 KMAnju-2021 changed the title [WIP]Add IPV4 Kind CI Job support for cloud jenkins Add IPV4 Kind CI Job support for cloud jenkins Sep 30, 2024
@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-ipv6-networkpolicy

@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-kind-cloud-conformance
/test-kind-cloud-e2e

@KMAnju-2021 KMAnju-2021 force-pushed the cloud-kind-jobs branch 2 times, most recently from 0ce972c to aa10062 Compare October 1, 2024 06:29
@KMAnju-2021
Copy link
Contributor Author

/test-kind-all-features-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-kind-whole-conformance

antoninbas
antoninbas reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @XinShuYang on this one but I have 2 questions:

  • I see changes related to IPv6 in the PR (/test-kind-cloud-ipv6-only-networkpolicy), but the PR title seems to indicate that the changes are for IPv4 only?
  • do we really have to change the trigger phrase to include "cloud" (e.g., test-kind-e2e -> test-kind-cloud-e2e) or can we keep the same ones? If I understand this PR correctly, "cloud" just means that the tests are being run in the public cloud (GCP)?

@XinShuYang
Copy link
Contributor

I'll defer to @XinShuYang on this one but I have 2 questions:

* I see changes related to IPv6 in the PR (`/test-kind-cloud-ipv6-only-networkpolicy`), but the PR title seems to indicate that the changes are for IPv4 only?

You're right, Antonin. The aim of this PR is to migrate all kinds of jobs to the cloud Jenkins according to #6698, not just those for IPv4. @KMAnju-2021 You can include this issue number in the commit message for the future task tracking.

* do we really have to change the trigger phrase to include "cloud" (e.g., `test-kind-e2e -> test-kind-cloud-e2e`) or can we keep the same ones? If I understand this PR correctly, "cloud" just means that the tests are being run in the public cloud (GCP)?

I share the same view. I've discussed this offline with @KMAnju-2021 , and we agree that there is no need to include "cloud" in the kind job name.

@KMAnju-2021 KMAnju-2021 changed the title Add IPV4 Kind CI Job support for cloud jenkins Migrate kind jobs to the cloud Jenkins Oct 2, 2024
@KMAnju-2021
Copy link
Contributor Author

/test-kind-e2e

@KMAnju-2021 KMAnju-2021 force-pushed the cloud-kind-jobs branch 2 times, most recently from 13eb730 to 3491923 Compare October 7, 2024 05:26
@XinShuYang
Copy link
Contributor

/test-kind-ipv6-all

1 similar comment
@KMAnju-2021
Copy link
Contributor Author

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor Author

/test-kind-ipv6-networkpolicy

@rajnkamr
Copy link
Contributor

/test-all

@KMAnju-2021
Copy link
Contributor Author

/test-kind-ipv6-all

@KMAnju-2021
Copy link
Contributor Author

/test-kind-whole-conformance
/test-kind-all-features-conformance

XinShuYang
XinShuYang reviewed Nov 5, 2024
View reviewed changes
ci/jenkins/test.sh Outdated Show resolved Hide resolved
@XinShuYang
Copy link
Contributor

/test-all-features-conformance
/test-whole-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-all-features-conformance

@KMAnju-2021
Copy link
Contributor Author

/test-whole-conformance

XinShuYang
XinShuYang approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@XinShuYang XinShuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

antoninbas
antoninbas approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe at some point we can stop documenting the /test-kind-* commands, if the corresponding /test-* command does the same thing (e.g., /test-kind-whole-conformance and /test-whole-conformance seem to be aliases).

@antoninbas antoninbas merged commit be1b08d into antrea-io:main Nov 7, 2024
50 of 54 checks passed
@XinShuYang
Copy link
Contributor

LGTM Maybe at some point we can stop documenting the /test-kind-* commands, if the corresponding /test-* command does the same thing (e.g., /test-kind-whole-conformance and /test-whole-conformance seem to be aliases).

Yes, in the second stage of job migration, we plan to remove redundant jobs, will include this enhancement in the next release with job yaml update. cc @KMAnju-2021

@rajnkamr rajnkamr mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajnkamr rajnkamr rajnkamr left review comments

@XinShuYang XinShuYang XinShuYang approved these changes

@antoninbas antoninbas antoninbas approved these changes

@luolanzone luolanzone Awaiting requested review from luolanzone

Assignees
No one assigned
Labels
area/test/infra Issues or PRs related to test infrastructure (Jenkins configuration, Ansible playbook, Kind wrappers area/test/jenkins Issue about jenkins setup code
Projects
None yet
Milestone
Antrea v2.3 release
Development

Successfully merging this pull request may close these issues.
5 participants
@KMAnju-2021 @antrea-bot @XinShuYang @rajnkamr @antoninbas