Cleanup InstanceOperations API for active scans/compactions #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the API for getting active scans and active compactions. The new API has been updated to just use a collection of servers instead of trying to also support other arguments (like a single server). Other methods were removed if new or deprecated if old, such as getActiveCompactions(). Getting active scans was updated to be multi-threaded like getting active compactions, and they now share the same code. If there are not multiple servers to query then the code now just uses a direct executor to prevent creating a thread pool. The listscans command was updated to take advantage of the new API and to use multiple threads to collect the scans to speed things up. Lastly, the tests have been updated to account for the API changes. This closes apache#5096
core/src/main/java/org/apache/accumulo/core/client/admin/ActiveScan.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/ActiveScanImpl.java
Show resolved
Hide resolved
core/src/main/java/org/apache/accumulo/core/clientImpl/InstanceOperationsImpl.java
Outdated
Show resolved
Hide resolved
| as.getScanid(), as.getSsiList(), as.getSsio())); | ||
| }); | ||
| } catch (AccumuloException | AccumuloSecurityException e) { | ||
| return Stream.of("ERROR " + e.getMessage()); |
There was a problem hiding this comment.
That is an interesting way to propagate the error message.
|
@keith-turner - this is ready for another review after the latest updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the API for getting active scans and active compactions. The new API has been updated to just use a collection of servers instead of trying to also support other arguments (like a single server). Other methods were removed if new or deprecated if old, such as getActiveCompactions().
Getting active scans was updated to be multi-threaded like getting active compactions, and they now share the same code. If there are not multiple servers to query then the code now just uses a direct executor to prevent creating a thread pool.
The listscans command was updated to take advantage of the new API and to use multiple threads to collect the scans to speed things up.
Lastly, the tests have been updated to account for the API changes.
This closes #5096