Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-44705: [MATLAB][PACKAGING] Update the crossbow MATLAB workflow to use macOS 13 instead of macOS 12 #44858

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

sgilmore10
Copy link
Member

@sgilmore10 sgilmore10 commented Nov 26, 2024

Rationale for this change

GitHub actions has started the deprecation process for macOS 12, which will be completed by December 3rd, 2024 according to this issue. The MATLAB CI workflow has already been updated to use macOS 13 instead of macOS 12 (thanks @kou for making this change!), but the crossbow MATLAB workflow still uses macOS 12. We need to update this workflow to use macOS 13.

What changes are included in this PR?

  1. Updated the MATLAB Crossbow GitHub workflow to use macOS 13 instead of macOS 12.

Are these changes tested?

  1. Yes. Ran a crossbow job: https://github.com/ursacomputing/crossbow/actions/runs/12033796012/job/33548796169.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the awaiting review Awaiting review label Nov 26, 2024
@sgilmore10
Copy link
Member Author

@github-actions crossbow submit matlab

Copy link

Revision: af10420

Submitted crossbow builds: ursacomputing/crossbow @ actions-7a843f5768

Task Status
matlab GitHub Actions

@sgilmore10 sgilmore10 marked this pull request as ready for review November 26, 2024 15:42
@kevingurney
Copy link
Member

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Nov 26, 2024
@sgilmore10 sgilmore10 merged commit b6a844a into apache:main Nov 26, 2024
9 checks passed
@sgilmore10 sgilmore10 removed the awaiting merge Awaiting merge label Nov 26, 2024
@sgilmore10 sgilmore10 deleted the GH-44705 branch November 26, 2024 15:49
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit b6a844a.

There were 144 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 51 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants