MINOR: [C++] Add missing header for Orc adapter #44876
Open
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Very minor. This source file cannot be compiled on its own manually, due to missing stringstream headers. This fixes that. Otherwise we get
implicit instantiation of undefined templateerrors.Context is we build Apache Arrow in a separate build system, Buck. As such, we do not (and cannot) 100% mirror the CMake build. In the past we've also had to patch header issues like: 529e08c. Thus, this change is for posterity to avoid having to custom patches on every new release.
What changes are included in this PR?
Adds which is used here:
https://github.com/apache/arrow/blob/main/cpp/src/arrow/adapters/orc/util.cc#L1226
Are these changes tested?
N/A
Are there any user-facing changes?
No