sandbox: request remote execution output as a directory digest #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abderrahim
requested review from
gtristan,
juergbi,
BenjaminSchubert and
cs-shadow
as code owners
abderrahim
force-pushed
the
abderrahim/re-tree-only
branch
from
7b0cfa8
to
603d804
Compare
juergbi
reviewed
Oct 14, 2024
It is used by the artifact/source caches and will be used by the remote execution sandbox
abderrahim
force-pushed
the
abderrahim/re-tree-only
branch
from
603d804
to
8aeae54
Compare
juergbi
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us an output that is easier to manipulate given we're using buildbox-casd, and allows to avoid a whole class of bugs such as #1842 and #1961
The old code for handling the output as a Tree is kept for now as the remote execution spec recommends using it as a fallback