-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIVE-28638: Refactor stats handling in StatsRecordingThreadPool #5557
base: master
Are you sure you want to change the base?
Conversation
f9fb1f2
to
834a9a1
Compare
834a9a1
to
8cf875a
Compare
llap-common/src/java/org/apache/hadoop/hive/llap/LlapThreadLocalStatistics.java
Outdated
Show resolved
Hide resolved
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StatsRecordingThreadPool.java
Show resolved
Hide resolved
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/StatsRecordingThreadPool.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments!
thanks, responded to those, please let me know if a follow-up needed somewhere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the answers!
8cf875a
to
83041f1
Compare
Quality Gate passedIssues Measures |
What changes were proposed in this pull request?
Refactoring StatsRecordingThreadPool and creating a new class LlapThreadLocalStatistics.
Why are the changes needed?
Describe in jira.
Does this PR introduce any user-facing change?
No.
Is the change a dependency upgrade?
No.
How was this patch tested?
Unit tests were added for the new class LlapThreadLocalStatistics.
Tested on a cluster (using file + s3), before/after results were almost the same. Ignoring <1% difference between different runs.
E.g. without patch
1.
with patch:
1.