feat: Add support for default values on metadata properties #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stancl
reviewed
Jul 15, 2024
refactor: Remove comment
owenconti
force-pushed
the
default-values
branch
from
4238174
to
bcdbd85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for attributes to define default values. This allows us to remove a lot of boilerplate code for attribute values that are optional.
For example, we have an enum for an instrument type and each type can optionally be marked as deprecated. Currently, we have to have a
IsDeprecatedattribute on every single enum case, when only 2 out of 15 types are currently deprecated.This PR would allow us to only add code for the few types that are actually deprecated, by defaulting the method to return
false.