Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1320 - Add Conn Description as Parameter #1361

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

erdos2n
Copy link
Contributor

@erdos2n erdos2n commented Aug 18, 2023

Description

Describe the purpose of this pull request.

🎟 Issue(s)

Related #XXX

🧪 Functional Testing

List the functional testing steps to confirm this feature or fix.

📸 Screenshots

Add screenshots to illustrate the validity of these changes.

📋 Checklist

  • [X ] Rebased from the main (or release if patching) branch (before testing)
  • [ X] Ran make test before taking out of draft
  • [X ] Ran make lint before taking out of draft
  • [ X] Added/updated applicable tests
  • Tested against Astro-API (if necessary).
  • Tested against Houston-API and Astronomer (if necessary).
  • Communicated to/tagged owners of respective clients potentially impacted by these changes.
  • Updated any related documentation

@erdos2n erdos2n linked an issue Aug 18, 2023 that may be closed by this pull request
4 tasks
@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.77%. Comparing base (a8d64c9) to head (86eaa3e).

Files Patch % Lines
settings/settings.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1361   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files         114      114           
  Lines       16700    16704    +4     
=======================================
+ Hits        14491    14495    +4     
+ Misses       1323     1322    -1     
- Partials      886      887    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunkickr
Copy link
Contributor

@erdos2n where you able to test this change with a local airflow settings file

@kushalmalani
Copy link
Contributor

@erdos2n @sunkickr What's the latest on this PR?

@erdos2n erdos2n requested a review from vandyliu as a code owner May 15, 2024 14:03
@sunkickr
Copy link
Contributor

This just needs to be tested and validated locally

@kushalmalani
Copy link
Contributor

@sunkickr If we can test and post screenshots, we can move forward with the review process and close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Connection Description field to Airflow settings File
3 participants