godownloader refactor for allow using a GH Token, other improvements #1673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
releases/latest
since we never make a call togithub_release()
without supplying a tag/version so that condition is never met.🧪 Functional Testing
📋 Checklist
I didn't both setting up a local astro env to test against because this is only a change the the downloader script, not actually changes to the CLI code. If I still need to do this, LMK and I'll get my env setup for it.
But because this script is what's returned from
curl -sSL install.astronomer.io
and in all of our CLI install docs, this should be reviewed closely!make test
before taking out of draftmake lint
before taking out of draft