feat(core/state): async trie prefetching #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Should remove these lines https://github.com/ava-labs/libevm/pull/76/files#diff-58140c10803d5c33def41482e87d096548e88382aacc21aa7dbee1e918915870R342-R350 to match the subnet-evm implementation: ava-labs/subnet-evm#1395
darioush
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Performs trie prefetching concurrently, required for equivalent performance with
coreth/subnet-evmimplementations.How this works
StateDB.StartPrefetcher()accepts variadic options (for backwards compatibility of function signatures). An option to specify aWorkerPoolis provided which, if present, is used to callTrie.Get{Account,Storage}(); the pool is responsible for concurrency but does not need to be able to wait on the work as that is handled by this change.How this was tested
Unit test demonstrating hand-off of work to a
WorkerPoolas well as API-guaranteed ordering of events.