Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deletion protection on BackupTable #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Olesp
Copy link

@Olesp Olesp commented Oct 23, 2023

Description of changes: This enable the deletion protection on the backup table. This prevent from any accidental deletion.
This is considered as a fail when using the cfn-lint command.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mikeols mikeols added the enhancement New feature or request label Oct 25, 2023
@mikeols
Copy link
Member

mikeols commented Oct 26, 2023

Thank you @Olesp! We will review this change. We cannot merge these PRs directly, but will incorporate it into our next release. This change may have unintended consequences for some users, such as leaving tables around that you aren't expecting to remain after a stack deletion. We may implement this using a parameter that defaults to false, but allows the user to change it upon deploy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants