fix(dynamodb): fix - addToResourcePolicy() tableV2 #31114
Conversation
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
LeeroyHannigan
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-community-review
| @@ -431,11 +431,11 @@ export abstract class TableBaseV2 extends Resource implements ITableV2, IResourc | |||
| if (options.tableActions) { | |||
| const resourceArns = [this.tableArn]; | |||
| this.hasIndex && resourceArns.push(`${this.tableArn}/index/*`); | |||
| return Grant.addToPrincipalOrResource({ | |||
| return Grant.addToPrincipal({ | |||
There was a problem hiding this comment.
Why is this the right fix? AFAIK, addToPrincipalOrResource will first call addToPrincipal first anyway. My guess of the root cause is that users can call addToResourcePolicy method on tableV2 construct, but resourcePolicy is not created as a lazy variable, thus it will only have the resource policy when construct is first defined.
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
Are there any updates to this PR or is there another PR that supersedes this one? |
There are still some refinements needed. You can add the policy directly to the constructor without the need to call addToResourcePolicy |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
|
Comments on closed issues and PRs are hard for our team to see. |
aws-cdk-automation
removed
the
pr/needs-community-review
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Issue # (if applicable)
Closes #30793
Reason for this change
addToResourcePolicy()had no effect.Description of changes
Fixed the bug which created a resourcePolicy object at a higher level
Description of how you validated changes
integ and unit tests included
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license