Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ec2-alpha): do not use string comparison in rangesOverlap #32269

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

awsdro
Copy link

@awsdro awsdro commented Nov 25, 2024

Issue #32145

Closes #32145.

Reason for this change

The rangesOverlap method was using string comparison to check if IP ranges overlapped.

Description of changes

The rangesOverlap method was updated to compare IP ranges using the ip-num library

Description of how you validated changes

Added two unit tests to verify correct behavior

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2024 05:28
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Nov 25, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@awsdro awsdro changed the title Do not use string comparison in rangesOverlap fix(ec2-alpha): Do not use string comparison in rangesOverlap Nov 25, 2024
@awsdro awsdro changed the title fix(ec2-alpha): Do not use string comparison in rangesOverlap fix(ec2-alpha): do not use string comparison in rangesOverlap Nov 25, 2024
@awsdro awsdro changed the title fix(ec2-alpha): do not use string comparison in rangesOverlap fix(ec2-alpha): do not use string comparison in rangesOverlap Nov 25, 2024
@awsdro
Copy link
Author

awsdro commented Nov 25, 2024

Clarification Request: I added some unit tests to check the behavior of the updated method, is that enough?

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Nov 25, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7182ddd
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2-alpha): rangesOverlap utility function is wrong
2 participants