Skip to content

Commit

Permalink
Fix %%gremlin profile serializer issue on Neptune DB <=1.2.x (#694)
Browse files Browse the repository at this point in the history
* Use backwards compatible default serializer for Gremlin profile

* update changelog
  • Loading branch information
michaelnchin authored Sep 18, 2024
1 parent 077c118 commit 3d2bfd6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions ChangeLog.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Starting with v1.31.6, this file will contain a record of major features and upd
- Added `--export-to` JSON file option to `%%graph_notebook_config` ([Link to PR](https://github.com/aws/graph-notebook/pull/684))
- Improved iPython config directory retrieval logic ([Link to PR](https://github.com/aws/graph-notebook/pull/687))
- Fixed `%db_reset` output for token modes ([Link to PR](https://github.com/aws/graph-notebook/pull/691))
- Fixed `%%gremlin profile` serialization issue on Neptune DB v1.2 and older ([Link to PR](https://github.com/aws/graph-notebook/pull/694))
- Use `extras_require` to specify tests ([Link to PR](https://github.com/aws/graph-notebook/pull/688))
- Updated Gremlin HTTP requests, fixed handling of internal error responses ([Link to PR](https://github.com/aws/graph-notebook/pull/692))

Expand Down
4 changes: 2 additions & 2 deletions src/graph_notebook/magics/graph_magic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1127,9 +1127,9 @@ def gremlin(self, line, cell, local_ns: dict = None):
'the profile report by default.')
parser.add_argument('--profile-chop', type=int, default=250,
help='Property to specify max length of profile results string. Default is 250')
parser.add_argument('--profile-serializer', type=str, default='GRAPHSON_V3_UNTYPED',
parser.add_argument('--profile-serializer', type=str, default='GRAPHSON_V3',
help='Specify how to serialize results. Allowed values are any of the valid MIME type or '
'TinkerPop driver "Serializers" enum values. Default is GRAPHSON_V3_UNTYPED')
'TinkerPop driver "Serializers" enum values. Default is GRAPHSON_V3')
parser.add_argument('--profile-indexOps', action='store_true', default=False,
help='Show a detailed report of all index operations.')
parser.add_argument('--profile-debug', action='store_true', default=False,
Expand Down

0 comments on commit 3d2bfd6

Please sign in to comment.