Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove swift.bzl, the granular targets should be used #1325

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Remove swift.bzl, the granular targets should be used #1325

wants to merge 2 commits into from

Conversation

brentleyjones
Copy link
Collaborator

RELNOTES: None
PiperOrigin-RevId: 470010567
(cherry picked from commit 9fa3a7a)

@brentleyjones
Copy link
Collaborator Author

brentleyjones commented Oct 1, 2024 •
edited
Loading

Depends on #1324.

brentleyjones referenced this pull request Oct 1, 2024
@thomasvl @swiple-rules-gardener
Remove swift.bzl, the granular targets should be used.
9fa3a7a 
RELNOTES: None
PiperOrigin-RevId: 470010567
@brentleyjones
Copy link
Collaborator Author

brentleyjones commented Oct 1, 2024 •
edited
Loading

When #1329 lands this will need to be adjusted.

@brentleyjones
Move the //swift:swift target
34e7b28 
This makes cherry-picks easier, since it will be moved here as part of a cherry-pick that we have to take later.

Signed-off-by: Brentley Jones <[email protected]>
@brentleyjones brentleyjones force-pushed the bj/remove-swift.bzl-the-granular-targets-should-be-used branch from 5f9c3b7 to 9b773b9 Compare October 4, 2024 15:18
@thomasvl @brentleyjones
Remove swift.bzl, the granular targets should be used
61318ed 
RELNOTES: None
PiperOrigin-RevId: 470010567
(cherry picked from commit 9fa3a7a)
Signed-off-by: Brentley Jones <[email protected]>
@brentleyjones brentleyjones force-pushed the bj/remove-swift.bzl-the-granular-targets-should-be-used branch from 9b773b9 to 61318ed Compare October 4, 2024 15:19
@brentleyjones
Copy link
Collaborator Author

We should probably update uses out in the ecosystem, e.g.:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luispadron luispadron luispadron approved these changes

@aaronsky aaronsky Awaiting requested review from aaronsky aaronsky will be requested when the pull request is marked ready for review aaronsky is a code owner

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick will be requested when the pull request is marked ready for review BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith will be requested when the pull request is marked ready for review keith is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob will be requested when the pull request is marked ready for review mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii will be requested when the pull request is marked ready for review thii is a code owner

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brentleyjones @luispadron @thomasvl