Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove warnings from defusedxml package #1

Open
wants to merge 1 commit into
base: open-release/palm.master
Choose a base branch
from

Conversation

diegovr
Copy link

@diegovr diegovr commented Jun 30, 2023

Description

Issue: openedx/public-engineering#146

  • Refactor the deprecated defusedxml package which will no longer be supported.
    • The current python version used(python3.8) supports the xml.etree.ElementTree package which replace the old package (defusedxml).
  • Fixed the Deprecation Warnings by making this change.

Supporting information

The best references to why it was deprecated I could find are here:

Testing instructions

To check and find from where I get the same warning, I run the unit tests inside the lms container (by running make dev.shell.lms) and I could found that the tests which use the deprecated package are from openedx/core/lib/tests/ path so I used pytest to confirm that.

Then after the changes I re-run the tests and the warning no longer appeared.

Other information

  • This change can also be the first step to deprecate/remove the defusedxml package since is used only in this section.

@diegovr diegovr force-pushed the diegovr/RemoveDeprecatedWarning branch 2 times, most recently from 5e6063e to e32f342 Compare July 3, 2023 01:14
@diegovr diegovr force-pushed the diegovr/RemoveDeprecatedWarning branch from e32f342 to acbbc8a Compare July 3, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant