sanitizing the path and update package json #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashLadha
reviewed
Jan 23, 2020
| @@ -78,7 +78,7 @@ function LocalBinary(){ | |||
| this.binaryPath = function(conf, callback){ | |||
| var destParentDir = this.getAvailableDirs(); | |||
| var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal'; | |||
| var binaryPath = path.join(destParentDir, destBinaryName); | |||
| var binaryPath = '"' + path.join(destParentDir, destBinaryName) + '"'; | |||
There was a problem hiding this comment.
Isn't the sanitization of the path can be handled by this function
elukoyanov
reviewed
Jan 27, 2020
| @@ -20,6 +20,7 @@ | |||
| "https-proxy-agent": "^2.2.1", | |||
| "is-running": "^2.0.0", | |||
| "ps-tree": "=1.1.1", | |||
| "selenium-webdriver": "^4.0.0-alpha.1", | |||
| @@ -78,7 +78,7 @@ function LocalBinary(){ | |||
| this.binaryPath = function(conf, callback){ | |||
| var destParentDir = this.getAvailableDirs(); | |||
| var destBinaryName = (this.windows) ? 'BrowserStackLocal.exe' : 'BrowserStackLocal'; | |||
| var binaryPath = path.join(destParentDir, destBinaryName); | |||
| var binaryPath = '"' + path.join(destParentDir, destBinaryName) + '"'; | |||
There was a problem hiding this comment.
Why does binaryPath needs double quotes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.