Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate trailing '.' in unambiguous type name cases #224

Merged
merged 12 commits into from
Dec 8, 2023
Merged

Tolerate trailing '.' in unambiguous type name cases #224

merged 12 commits into from
Dec 8, 2023

Conversation

Alfus
Copy link
Contributor

@Alfus Alfus commented Dec 8, 2023

While still reporting an error. The important case for code completion is extension type names. See #200

@Alfus Alfus requested a review from jhump December 8, 2023 02:04
jhump
jhump approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@jhump jhump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, for the ambiguous case -- the type in a field definition -- I think you can easily handle that as productions that are simply missing the name, since that is the token that causes a conflict, confused for being part of the prior type.

parser/parser_test.go Show resolved Hide resolved
Base automatically changed from alfus/optnamedot to main December 8, 2023 17:26
@Alfus Alfus merged commit 93a9ef1 into main Dec 8, 2023
8 checks passed
@Alfus Alfus deleted the alfus/typedot branch December 8, 2023 17:43
kralicky pushed a commit to kralicky/protocompile that referenced this pull request Feb 7, 2024
@Alfus @kralicky
Tolerate trailing '.' in unambiguous type name cases (bufbuild#224)
3e95be1 
While still reporting an error. The important case for code completion
is extension type names. See
bufbuild#200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhump jhump jhump approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alfus @jhump