WIP: tar plugin move #1410
WIP: tar plugin move #1410
Conversation
Use the one from bst-plugins-experimental instead
|
In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:39 changed the description |
|
In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:39 Not sure I will have time to finish this, so please feel free to finish this off |
|
In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:40 changed the description |
|
In GitLab by [Gitlab user @valentindavid] on Dec 5, 2019, 10:05 Commented on tests/conftest.py line 115 I do not think we can do that. There are multiple integration tests that runs over multiple plugins. They have to continue to run for tar. And we cannot move them to the bst-experimental-plugins unless we move all of them. |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Dec 5, 2019, 10:10 Commented on tests/conftest.py line 115 Once https://gitlab.com/BuildStream/buildstream/merge_requests/1607 is resolved, that would be done automatically, we would not need to move the tests at all. Also, those tests would also be run in the bst-plugins-experimental repo. However, I would feel more comfortable having the testing entirely in place before moving more of those plugins |
|
In GitLab by [Gitlab user @jjardon] on Dec 5, 2019, 10:55 Commented on tests/conftest.py line 115 [Gitlab user @valentindavid] mm, can we depend on bst-plugins-external then? I think we already do |
|
In GitLab by [Gitlab user @valentindavid] on Dec 5, 2019, 11:41 Commented on tests/conftest.py line 115 [Gitlab user @jjardon], Yes, we already do. I just pointed out we cannot remove this line, because it disables lots of tests that are not moved to the plugin repository. |
|
In GitLab by [Gitlab user @jjardon] on Jan 15, 2020, 11:36 mentioned in merge request bst-plugins-experimental!56 |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Jan 15, 2020, 12:23 Commented on tests/conftest.py line 115 Note that this is outdated. We do NOT depend on bst-plugins-experimental anymore. This should be moved to the other repository at the same time we move the plugin |
|
In GitLab by [Gitlab user @jjardon] on Jan 15, 2020, 13:05 added 189 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 15, 2020, 13:11 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Jan 17, 2020, 04:56 added 2 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 17, 2020, 05:02 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Jan 17, 2020, 05:09 added 22 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 10:06 added 10 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 10:10 resolved all threads |
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 10:12 added 1 commit
|
|
In GitLab by [Gitlab user @BenjaminSchubert] on Jan 20, 2020, 10:23 Commented on doc/examples/autotools/project.conf line 15 Those tests will fail without the plugins installed |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Jan 20, 2020, 10:23 Commented on .gitlab-ci.yml line 354 Would it make sense to use the tagged version now that we have tags on bst-plugins-experimental? |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Jan 20, 2020, 10:23 Commented on tox.ini line 176 I think it might be better to use the same version used as for the plugins tests: |
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 13:32 Commented on .gitlab-ci.yml line 354 mmm, that was the output of |
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 13:36 Commented on tox.ini line 176 changed this line in version 10 of the diff |
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 13:36 added 1 commit
|
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 13:37 Commented on tox.ini line 176 Done, thanks |
|
In GitLab by [Gitlab user @jjardon] on Jan 20, 2020, 13:41 Commented on doc/examples/autotools/project.conf line 15 [Gitlab user @BenjaminSchubert] is it possible to add a section there or we need to add the plugins to the docker image? or how you propose to solve this? |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Jan 20, 2020, 13:43 Commented on doc/examples/autotools/project.conf line 15 I was wondering if we should go for an approach where we tag tests requiring external plugins ([Gitlab user @pytest].mark.plugins) and then run them at the same time as the source test plugins? That would allow us to have more complete and easy tests setup, while keeping the strict separation for the basic tests and such. I'm happy to start a ML thread around it if you think that is worth it |
|
In GitLab by [Gitlab user @tpollard] on Jan 21, 2020, 11:42 Commented on doc/examples/autotools/project.conf line 15 Sounds reasonable to me [Gitlab user @BenjaminSchubert] and will be needed for other plugins when they're extracted |
|
In GitLab by [Gitlab user @jjardon] on Jan 27, 2020, 12:29 Commented on .gitlab-ci.yml line 354 changed this line in version 11 of the diff |
|
In GitLab by [Gitlab user @jjardon] on Jan 27, 2020, 12:29 added 7 commits
|
|
In GitLab by [Gitlab user @jjardon] on Jan 27, 2020, 12:30 Commented on .gitlab-ci.yml line 354 Done now, thanks |
|
In GitLab by [Gitlab user @tpollard] on Mar 18, 2020, 13:56 Commented on doc/examples/autotools/project.conf line 15 Are we still aiming for this approach [Gitlab user @BenjaminSchubert]? |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Mar 23, 2020, 17:01 Commented on doc/examples/autotools/project.conf line 15 I would say ideally yes, but I don't have time to take care of this right now. I'm happy to help if someone wants to take over. Otherwise I'll see when I can find time for it. Unless someone has a better idea. For me it still seems kind of gross, but should work in theory |
|
In GitLab by [Gitlab user @willsalmon] on Mar 25, 2020, 13:46
Ahh i had miss read your comment, i need a bit more first |
|
In GitLab by [Gitlab user @willsalmon] on Mar 25, 2020, 13:47 Those are all you need for the non |
See original merge request on GitLab
In GitLab by [Gitlab user @jjardon] on Nov 30, 2019, 15:37
Part of #1224
MRs in bst-plugins-experimental: