Draft: utils.py: Remove the (?ms) switch at the start of _glob2re #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ?ms switch stands for multiline output. This switch is used nowhere in our codebase. It also is problematic in mutliple places where its use is deprecated, as now they need to be at the start of an expression, which is not the case in all the calls to it that we are doing. If someone wants the same functionality, they should add it explictely after calling _glob2re
|
In GitLab by [Gitlab user @BenjaminSchubert] on Aug 28, 2020, 15:01 changed the description |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Aug 29, 2020, 11:58 marked as a Work In Progress |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Aug 29, 2020, 11:58 changed the description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See original merge request on GitLab
In GitLab by [Gitlab user @BenjaminSchubert] on Aug 28, 2020, 15:00
The ?ms switch stands for multiline output.
This switch is used nowhere in our codebase.
It also is problematic in multiple places where its use is deprecated since python 3.7,
as now they need to be at the start of an expression, which is not the
case in all the calls to it that we are doing.
If someone wants the same functionality, they should add it explictely
after calling _glob2re
TODO
Still need to add a test to see how BuildStream behaves with split files that have such characters in them