Simplify source workspace tests #1432
Conversation
This test seems to be copy pasted from our tests around workspaces and doesn't need to be so complicated
This is to remove some hoops that are currently used, that do not fit well with most of the style in the code. It also removes indirections and make the test easier to understand
|
In GitLab by [Gitlab user @juergbi] on Oct 13, 2020, 17:22 Commented on src/buildstream/testing/_sourcetests/workspace.py line 49
|
|
In GitLab by [Gitlab user @juergbi] on Oct 13, 2020, 17:23 approved this merge request |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 13, 2020, 17:26 Commented on src/buildstream/testing/_sourcetests/workspace.py line 49 Ah good catch, i'll fix this and send for a merge |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 13, 2020, 17:43 added 4 commits
|
|
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 13, 2020, 17:47 resolved all threads |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 13, 2020, 17:47 assigned to [Gitlab user @marge-bot123] |
|
In GitLab by [Gitlab user @marge-bot123] on Oct 13, 2020, 19:48 assigned to [Gitlab user @BenjaminSchubert] and unassigned [Gitlab user @marge-bot123] |
|
In GitLab by [Gitlab user @marge-bot123] on Oct 13, 2020, 19:48 I couldn't merge this branch: CI is taking too long. |
|
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 13, 2020, 21:35 assigned to [Gitlab user @marge-bot123] |
|
In GitLab by [Gitlab user @marge-bot123] on Oct 13, 2020, 23:35 unassigned [Gitlab user @marge-bot123] |
|
In GitLab by [Gitlab user @marge-bot123] on Oct 13, 2020, 23:35 I couldn't merge this branch: CI is taking too long. |
See original merge request on GitLab
In GitLab by [Gitlab user @BenjaminSchubert] on Oct 9, 2020, 12:46
Description
This simplifies the source workspace tests, by removing a lot of the complexity that got brought in by copying the workspace element tests