-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added repl context object #117
Conversation
@auvipy can u review this pls? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checking the code changes, it seems to be a big rewrite but without any additional test cases. it would be helpful to know more detail about the goal of the change
its just for giving the user full control over the prompt session object for utmost customization of the prompt. its also used for keeping track of each of its appropriate repl session, which will be useful if a repl is invoked inside an another repl therefore, this PR is more like a feature request |
@auvipy any more queries? |
why it was closed? |
@auvipy i included a small, dead code |
similar to click's context object, but its for keeping track on the promptsession object.
By this, the user can modify the prompt in runtime, can also change the prompt text, and view history.