Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nb_NO translation from Weblate #107

Merged
merged 4 commits into from
Jan 2, 2018
Merged

Add nb_NO translation from Weblate #107

merged 4 commits into from
Jan 2, 2018

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Dec 21, 2017

Proof of concept for #124

@jayvdb
Copy link
Member Author

jayvdb commented Dec 21, 2017

Travis doesnt like the commit message:

 Translated using Weblate (Norwegian Bokmål)

Currently translated at 100.0% (19 of 19 strings)

Translation: Coala/GCI Leaders
Translate-URL: hosted.weblate.org/projects/coala/gci-leaders/nb_NO

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'Translated'
Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

I've updated the template shortlog, so this shouldnt occur again

@@ -0,0 +1,21 @@
{
"page-title": "Nåværende",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the other i18n translations, 2 space indentations are used. I don't mind either way, but we should keep it consistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting problem. These files come from Weblate, and its generator is not configurable as far as I can see.
So, I think we need to change our data files to match the Weblate ones.

Copy link
Member

@realslimshanky realslimshanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase the branch of your fork with the master of this repository.

@gitmate-bot
Copy link
Collaborator

Comment on aa1acbf, file static/js/i18n/nb_NO.json, line 4.

Line is longer than allowed. (121 > 80)

Origin: LineLengthBear, Section: all.linelength.

@gitmate-bot
Copy link
Collaborator

Comment on aa1acbf, file static/js/i18n/nb_NO.json, line 6.

Line is longer than allowed. (99 > 80)

Origin: LineLengthBear, Section: all.linelength.

@gitmate-bot
Copy link
Collaborator

Comment on aa1acbf, file static/i18n/es.json, line 2.

This file can be reformatted by sorting keys and following indentation.

Origin: JSONFormatBear, Section: all.json-i18n.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpkkf9nfs0/static/i18n/es.json
+++ b/tmp/tmpkkf9nfs0/static/i18n/es.json
@@ -1,21 +1,21 @@
 {
-    "page-title": "Líderes actuales de Google Code-in 2017",
-    "last-updated": "Última actualización",
-    "order-info": "Los participantes líderes de cada organización (y sus respectivas cuentas de GitHub) están listados de forma aleatoria.",
+    "page-title": "L\u00edderes actuales de Google Code-in 2017",
+    "last-updated": "\u00daltima actualizaci\u00f3n",
+    "order-info": "Los participantes l\u00edderes de cada organizaci\u00f3n (y sus respectivas cuentas de GitHub) est\u00e1n listados de forma aleatoria.",
     "tasks-completed": "Tareas completadas",
     "gci-copyright": "Google Code-in y su logotipo son marcas registradas de Google Inc.",
-    "orgs-no-listed": "Organizacion(es) sin listado de líderes",
+    "orgs-no-listed": "Organizacion(es) sin listado de l\u00edderes",
     "passed": "$1% completado, aproximadamente $2 hasta que termine el periodo de tareas",
     "seconds-ago": "hace $1 {{PLURAL:$1|segundo|segundos}}",
     "minutes-ago": "hace $1 {{PLURAL:$1|minuto|minutos}}",
     "hours-ago": "hace $1 {{PLURAL:$1|hora|horas}}",
-    "days-ago": "hace $1 {{PLURAL:$1|día|días}}",
+    "days-ago": "hace $1 {{PLURAL:$1|d\u00eda|d\u00edas}}",
     "months-ago": "hace $1 {{PLURAL:$1|mes|meses}}",
-    "years-ago": "hace $1 {{PLURAL:$1|año|años}}",
+    "years-ago": "hace $1 {{PLURAL:$1|a\u00f1o|a\u00f1os}}",
     "seconds": "$1 {{PLURAL:$1|segundo|segundos}}",
     "minutes": "$1 {{PLURAL:$1|minuto|minutos}}",
     "hours": "$1 {{PLURAL:$1|hora|horas}}",
-    "days": "$1 {{PLURAL:$1|día|días}}",
+    "days": "$1 {{PLURAL:$1|d\u00eda|d\u00edas}}",
     "months": "$1 {{PLURAL:$1|mes|meses}}",
-    "years": "$1 {{PLURAL:$1|año|años}}"
+    "years": "$1 {{PLURAL:$1|a\u00f1o|a\u00f1os}}"
 }

@gitmate-bot
Copy link
Collaborator

Comment on aa1acbf, file static/i18n/pl.json, line 4.

This file can be reformatted by sorting keys and following indentation.

Origin: JSONFormatBear, Section: all.json-i18n.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpkkf9nfs0/static/i18n/pl.json
+++ b/tmp/tmpkkf9nfs0/static/i18n/pl.json
@@ -1,21 +1,21 @@
 {
     "page-title": "Obecni liderzy Google Code-in 2017",
     "last-updated": "Ostatnio aktualizowano",
-    "order-info": "Uczestnicy na prowadzeniu z każdej organizacji (i ich konta na GitHubie, jeśli dotyczy) wypisani są w kolejności losowej.",
-    "tasks-completed": "Ukończone zadania",
-    "gci-copyright": "Google Code-in i logo Google Code-in są znakami towarowymi Google Inc.",
-    "orgs-no-listed": "Organizacje bez wypisanych liderów",
-    "passed": "Ukończono $1%, pozostało około $2 do końca zajmowania zadań",
+    "order-info": "Uczestnicy na prowadzeniu z ka\u017cdej organizacji (i ich konta na GitHubie, je\u015bli dotyczy) wypisani s\u0105 w kolejno\u015bci losowej.",
+    "tasks-completed": "Uko\u0144czone zadania",
+    "gci-copyright": "Google Code-in i logo Google Code-in s\u0105 znakami towarowymi Google Inc.",
+    "orgs-no-listed": "Organizacje bez wypisanych lider\u00f3w",
+    "passed": "Uko\u0144czono $1%, pozosta\u0142o oko\u0142o $2 do ko\u0144ca zajmowania zada\u0144",
     "seconds-ago": "$1 {{PLURAL:$1|sekunda|sekundy|sekund}} temu",
     "minutes-ago": "$1 {{PLURAL:$1|minuta|minuty|minut}} temu",
     "hours-ago": "$1 {{PLURAL:$1|godzina|godziny|godzin}} temu",
-    "days-ago": "$1 {{PLURAL:$1|dzień|dni}} temu",
-    "months-ago": "$1 {{PLURAL:$1|miesiąc|miesiące|miesięcy}} temu",
+    "days-ago": "$1 {{PLURAL:$1|dzie\u0144|dni}} temu",
+    "months-ago": "$1 {{PLURAL:$1|miesi\u0105c|miesi\u0105ce|miesi\u0119cy}} temu",
     "years-ago": "$1 {{PLURAL:$1|rok|lata|lat}} temu",
     "seconds": "$1 {{PLURAL:$1|sekunda|sekundy|sekund}}",
     "minutes": "$1 {{PLURAL:$1|minuta|minuty|minut}}",
     "hours": "$1 {{PLURAL:$1|godzina|godziny|godzin}}",
-    "days": "$1 {{PLURAL:$1|dzień|dni}}",
-    "months": "$1 {{PLURAL:$1|miesiąc|miesiące|miesięcy}",
+    "days": "$1 {{PLURAL:$1|dzie\u0144|dni}}",
+    "months": "$1 {{PLURAL:$1|miesi\u0105c|miesi\u0105ce|miesi\u0119cy}",
     "years": "$1 {{PLURAL:$1|rok|lata|lat}}"
 }

@gitmate-bot
Copy link
Collaborator

Comment on 896d610, file static/js/i18n/nb_NO.json, line 4.

Line is longer than allowed. (121 > 80)

Origin: LineLengthBear, Section: all.linelength.

@gitmate-bot
Copy link
Collaborator

Comment on 896d610, file static/js/i18n/nb_NO.json, line 6.

Line is longer than allowed. (99 > 80)

Origin: LineLengthBear, Section: all.linelength.

Weblate uses four space indents for its i18n data files,
so the manually created data files should be the same style.

Also allow unicode in i18n files.

Related to #124
comradekingu and others added 3 commits January 2, 2018 12:08
Currently translated at 100.0% (19 of 19 strings)
New weblate translations need to be manually added
to the front-end.

Related to #124
@blazeu
Copy link
Member

blazeu commented Jan 2, 2018

ack 9a170ec 5267829 572c9bf d29de0a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants