-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cylc vip
(validate-install-play)
#5094
Conversation
6ec538a
to
5787a3a
Compare
(Looking forward to this - I am now gagging for |
@hjoliver @datamel - I have undrafted this PR - the functionality is ready for review. I'm going to have a look at whether I can add labels to the help output indicating which commands each option applies to - i.e. - --workflow-name -n Some info
+ --workflow-name -n [cylc install] Some info However, I don't see any reason this couldn't be follow in if you wanted to focus on getting this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the help docs to register while I get on with more thorough manual testing.
I have tested this with a basic workflow, no options just yet, all is working really well 🎉
#3896 - This PR draft, but currently implements the validate install play working practice. I think that it works in principle for the other working practices.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users