Fixed the AML parsing bug in case of emoticons or UTF-8 characters #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+83
to
+84
| parser = Parser() | ||
| aml_content = parser.parse(aml_text) |
There was a problem hiding this comment.
I noticed that the parser has several assert statements, that when triggered, will cause the server to return a 500 response without any clear indication of what went wrong. Could you wrap this in a try/except block and return a more informative response to the client? (If possible, it would be best if you could replace each "assert" statement in the parser with an exception with a custom error message, but if you don't completely understand the parser code then it's fine not to have this).
We will have to add the ability to show the error messages for non-200 responses in a future issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the new AML parser into the old kerckhoff and tested using many emojis and UTF-8 characters. Also tested that the weird bug with bulleted lists does not occur with this new parser.