-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency urllib3 to v2.2.2 [security] #352
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/pypi-urllib3-vulnerability
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
September 25, 2022 16:46
6f440c0
to
93f5c3e
Compare
renovate
bot
changed the title
Update dependency urllib3 to v1.26.5 [SECURITY]
Update dependency urllib3 to v1.25.9 [SECURITY]
Sep 25, 2022
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
December 8, 2022 01:42
93f5c3e
to
cbbf6d3
Compare
renovate
bot
changed the title
Update dependency urllib3 to v1.25.9 [SECURITY]
Update dependency urllib3 to v1.24.3 [SECURITY]
Dec 8, 2022
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
December 8, 2022 14:45
cbbf6d3
to
c7edfd2
Compare
renovate
bot
changed the title
Update dependency urllib3 to v1.24.3 [SECURITY]
Update dependency urllib3 to v1.25.9 [SECURITY]
Dec 8, 2022
renovate
bot
changed the title
Update dependency urllib3 to v1.25.9 [SECURITY]
Update dependency urllib3 to v1.24.3 [SECURITY]
Dec 8, 2022
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
December 8, 2022 17:45
c7edfd2
to
5410ff1
Compare
renovate
bot
changed the title
Update dependency urllib3 to v1.24.3 [SECURITY]
chore(deps): update dependency urllib3 to v1.24.3 [security]
Dec 17, 2022
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.24.3 [security]
chore(deps): update dependency urllib3 to v1.24.3 [security] - autoclosed
Dec 22, 2022
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.24.3 [security] - autoclosed
chore(deps): update dependency urllib3 to v1.24.3 [security]
Dec 22, 2022
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.24.3 [security]
chore(deps): update dependency urllib3 to v1.25.9 [security]
Jun 1, 2023
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
June 1, 2023 05:49
5410ff1
to
a03f048
Compare
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
August 23, 2023 02:48
a03f048
to
9441ffe
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.25.9 [security]
chore(deps): update dependency urllib3 to v1.26.17 [security]
Oct 3, 2023
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
October 3, 2023 01:42
9441ffe
to
9c4d344
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.26.17 [security]
chore(deps): update dependency urllib3 to v1.26.17 [security] - autoclosed
Oct 4, 2023
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.26.17 [security] - autoclosed
chore(deps): update dependency urllib3 to v1.26.17 [security]
Oct 4, 2023
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v1.26.17 [security]
chore(deps): update dependency urllib3 to v2.0.6 [security]
Oct 4, 2023
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
October 4, 2023 01:27
9c4d344
to
3b2593d
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.6 [security]
chore(deps): update dependency urllib3 to v2.0.7 [security]
Oct 17, 2023
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
October 17, 2023 23:07
3b2593d
to
5c24bd1
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.7 [security]
chore(deps): update dependency urllib3 to v2.0.7 [security] - autoclosed
Jan 18, 2024
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.7 [security] - autoclosed
chore(deps): update dependency urllib3 to v2.0.7 [security]
Jan 18, 2024
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
January 18, 2024 19:05
5c24bd1
to
34e5b6d
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.7 [security]
chore(deps): update dependency urllib3 to v2.0.7 [security] - autoclosed
Apr 3, 2024
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.7 [security] - autoclosed
chore(deps): update dependency urllib3 to v2.0.7 [security]
Apr 3, 2024
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
April 3, 2024 16:55
34e5b6d
to
96c7da0
Compare
renovate
bot
force-pushed
the
renovate/pypi-urllib3-vulnerability
branch
from
June 18, 2024 00:31
96c7da0
to
b2a0734
Compare
renovate
bot
changed the title
chore(deps): update dependency urllib3 to v2.0.7 [security]
chore(deps): update dependency urllib3 to v2.2.2 [security]
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
==2.0.4
->==2.2.2
GitHub Vulnerability Alerts
CVE-2023-43804
urllib3 doesn't treat the
Cookie
HTTP header special or provide any helpers for managing cookies over HTTP, that is the responsibility of the user. However, it is possible for a user to specify aCookie
header and unknowingly leak information via HTTP redirects to a different origin if that user doesn't disable redirects explicitly.Users must handle redirects themselves instead of relying on urllib3's automatic redirects to achieve safe processing of the
Cookie
header, thus we decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Cookie
header on requests, which is mostly typical for impersonating a browser.Remediation
redirects=False
when sending requests.Cookie
header.CVE-2023-45803
urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like
POST
) toGET
as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.From RFC 9110 Section 9.3.1:
Affected usages
Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.
Both of the following conditions must be true to be affected by this vulnerability:
Remediation
You can remediate this vulnerability with any of the following steps:
redirects=False
.redirects=False
and handle 303 redirects manually by stripping the HTTP request body.CVE-2024-37891
When using urllib3's proxy support with
ProxyManager
, theProxy-Authorization
header is only sent to the configured proxy, as expected.However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the
Proxy-Authorization
header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat theProxy-Authorization
HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the
Proxy-Authorization
header during cross-origin redirects to avoid the small chance that users are doing this on accident.Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the
Proxy-Authorization
header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.Affected usages
We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:
Proxy-Authorization
header without using urllib3's built-in proxy support.Remediation
Proxy-Authorization
header with urllib3'sProxyManager
.redirects=False
when sending requests.Proxy-Authorization
header.Release Notes
urllib3/urllib3 (urllib3)
v2.2.2
Compare Source
==================
Proxy-Authorization
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
.amt
to read methods ofhttp.client.HTTPResponse
as an alternative toNone
. (#​3122 <https://github.com/urllib3/urllib3/issues/3122>
__)typing.Self
. (#​3363 <https://github.com/urllib3/urllib3/issues/3363>
__)v2.2.1
Compare Source
==================
InsecureRequestWarning
was emitted for HTTPS connections when using Emscripten. (#​3331 <https://github.com/urllib3/urllib3/issues/3331>
__)HTTPConnectionPool.urlopen
to stop automatically casting non-proxy headers toHTTPHeaderDict
. This change was premature as it did not apply to proxy headers andHTTPHeaderDict
does not handle byte header values correctly yet. (#​3343 <https://github.com/urllib3/urllib3/issues/3343>
__)InvalidChunkLength
toProtocolError
when response terminates before the chunk length is sent. (#​2860 <https://github.com/urllib3/urllib3/issues/2860>
__)ProtocolError
to be more verbose on incomplete reads with excess content. (#​3261 <https://github.com/urllib3/urllib3/issues/3261>
__)v2.2.0
Compare Source
==================
Emscripten and Pyodide <https://urllib3.readthedocs.io/en/latest/reference/contrib/emscripten.html>
, including streaming support in cross-origin isolated browser environments where threading is enabled. (#​2951 <https://github.com/urllib3/urllib3/issues/2951>
)HTTPResponse.read1()
method. (#​3186 <https://github.com/urllib3/urllib3/issues/3186>
__)#​3284 <https://github.com/urllib3/urllib3/issues/3284>
__)when using proxy. (
#​2244 <https://github.com/urllib3/urllib3/issues/2244>
__)HTTPConnection.proxy_is_verified
andHTTPSConnection.proxy_is_verified
to be always set to a boolean after connecting to a proxy. It could be
None
in some cases previously. (#​3130 <https://github.com/urllib3/urllib3/issues/3130>
__)headers
passed in a request withjson=
would be mutated (#​3203 <https://github.com/urllib3/urllib3/issues/3203>
__)HTTPSConnection.is_verified
to be set toFalse
when connectingfrom a HTTPS proxy to an HTTP target. It was set to
True
previously. (#​3267 <https://github.com/urllib3/urllib3/issues/3267>
__)#​3268 <https://github.com/urllib3/urllib3/issues/3268>
__)#​3325 <https://github.com/urllib3/urllib3/issues/3325>
__)time with the
--integration
pytest flag. (#​3181 <https://github.com/urllib3/urllib3/issues/3181>
__)v2.1.0
Compare Source
==================
#​2680 <https://github.com/urllib3/urllib3/issues/2680>
__)#​2681 <https://github.com/urllib3/urllib3/issues/2681>
__)#​3143 <https://github.com/urllib3/urllib3/issues/3143>
__)#​3065 <https://github.com/urllib3/urllib3/issues/3065>
__)x-gzip
content-encoding. (#​3174 <https://github.com/urllib3/urllib3/issues/3174>
__)v2.0.7
Compare Source
==================
v2.0.6
Compare Source
==================
Cookie
header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set viaRetry.remove_headers_on_redirect
.v2.0.5
Compare Source
==================
#​3126 <https://github.com/urllib3/urllib3/issues/3126>
__)blocksize
ofHTTPConnection
classes to match high-level classes. Previously was 8KiB, now 16KiB. (#​3066 <https://github.com/urllib3/urllib3/issues/3066>
__)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.