Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: override traffic to cf #3879

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: override traffic to cf #3879

wants to merge 1 commit into from

Conversation

capJavert
Copy link
Contributor

@capJavert capJavert commented Nov 25, 2024

Changes

  • add middleware rewrite with percentage traffic override
  • allows to test the new deployment on prod traffic
  • if we ever need to kill it completely we just revert the deployment

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://cf-traffic-override.preview.app.daily.dev

@capJavert capJavert self-assigned this Nov 25, 2024
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Nov 25, 2024 10:49pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Nov 25, 2024 10:49pm

Comment on lines +18 to +21
path: '/',
maxAge: 1 * 60 * 60,
secure: !isDev,
httpOnly: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sets the override for the next 1 hour


export const config = {
matcher: [
'/((?!api|_next/static|_next/image|favicon|manifest.json|robots.txt|android-chrome).*)',
Copy link
Contributor Author

@capJavert capJavert Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not override static stuff because they would be requested from cf.daily.dev either way when main document is loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants