fix(ingest/kafka):add poll for admin client for oauth_cb #11985
+48
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
treff7es
approved these changes
Nov 28, 2024
| ) -> AdminClient: | ||
| client = AdminClient( | ||
| { | ||
| "group.id": "test", |
There was a problem hiding this comment.
Shouldn't this be some random group id?
test seems to be too generic, what if it already exists?
There was a problem hiding this comment.
That's true. I read some details here - https://developer.confluent.io/faq/apache-kafka/kafka-clients/#kafka-clients-what-is-groupid-in-kafka
How about "group.id": "datahub-kafka-ingestion", that shouldn't conflict, right ? I'm not sure about using completely random string.
There was a problem hiding this comment.
In this case, we actually do not consume any messages so any group id is fine, I think.
There was a problem hiding this comment.
I think this should work as it is datahub-specific, so there is less chance to collide
Co-authored-by: Tamas Nemeth <[email protected]>
Co-authored-by: Tamas Nemeth <[email protected]>
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on #11900
Checklist