Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite and implement }karmalink & }karmaunlink #9

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Rewrite and implement }karmalink & }karmaunlink #9

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b9d50c4
Replace parer with nom-based parser
dsprenkels Nov 7, 2020
ce57bb8
Cargo clippy run
dsprenkels Nov 7, 2020
e948c68
Implement printing of merged karma concepts
dsprenkels Nov 8, 2020
e77764a
parser: Fix bug caused by not matching eof
dsprenkels Nov 8, 2020
7464c3d
Refactor reply_to_karmafight_command
dsprenkels Nov 8, 2020
9d81936
karmafight: Rewrite to groups
dsprenkels Nov 8, 2020
daf3284
Fix notify after karma update
dsprenkels Nov 8, 2020
213d87c
Implement }karmamerge and }karmasplit
dsprenkels Nov 8, 2020
427fb0d
Improve error handling in karma.rs
dsprenkels Nov 17, 2020
d91c222
Remove unnecessary [..]
dsprenkels Nov 17, 2020
9e9b476
Cargo.toml: Add me as an author; NFC
dsprenkels Nov 17, 2020
5da9292
Impl Add on KarmaAmount
dsprenkels Nov 17, 2020
fde7705
Run cargo fmt
dsprenkels Nov 17, 2020
05d931a
register_votes: Use private struct instead of tuple
dsprenkels Nov 17, 2020
6b245dc
parse: Simplify modifier parser
dsprenkels Nov 17, 2020
6f3db1e
karma: Define Ord on KarmaStyle
dsprenkels Nov 17, 2020
309fb3b
karma: Remove unused KarmaStyle::default
dsprenkels Nov 17, 2020
c96706e
Remove redundant call to canonicalize_term
dsprenkels Nov 17, 2020
6bc1fc6
karma: Merge from_response into get_from_dazeus
dsprenkels Nov 17, 2020
6099edc
Cargo.toml: Add a trailing newline
dsprenkels Nov 17, 2020
e3498e6
handler: Add TODO-refactor comments
dsprenkels Nov 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
398 changes: 340 additions & 58 deletions Cargo.lock
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 12 additions & 13 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,20 @@
name = "dazeus-plugin-karma"
version = "0.1.0"
authors = ["Ruben Nijveld <[email protected]>"]
dsprenkels marked this conversation as resolved.
Show resolved Hide resolved
edition = "2018"

[dependencies.dazeus]
version = "0.4"

[dependencies.docopt]
version = "0.6"
[dependencies]
chrono = { version = "0.4.19", features = ["serde"] }
dazeus = "0.4"
docopt = "1.1.0"
env_logger = "0.8.1"
log = "0.4.11"
nom = "6.0.0"
serde = { version = "1.0.117", features = ["derive"] }
serde_json = "1.0.59"
dsprenkels marked this conversation as resolved.
Show resolved Hide resolved

[dependencies.rustc-serialize]
version = "0.3"

[dependencies.log]
version = "0.3"

[dependencies.env_logger]
version = "0.3"

[dependencies.chrono]
version = "0.2"
[profile.release]
overflow-checks = true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overhead is negligible, but why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the overhead is negligible and I hate overflow bugs. :P

Feel free to veto me on this.

24 changes: 0 additions & 24 deletions grammar.sh
View file
Open in desktop

This file was deleted.

6 changes: 4 additions & 2 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
#[derive(Debug)]
pub struct KarmaError {
descr: String
descr: String,
}

impl KarmaError {
pub fn new(descr: &str) -> KarmaError {
KarmaError { descr: descr.to_string() }
KarmaError {
descr: descr.to_string(),
}
}
}

Expand Down
Loading