Reply differently to questions than to statements. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Questions will now get a 'X% yes.' reply.
| @@ -35,6 +35,8 @@ | |||
| my ($self, $network, $sender, $channel, $command, $arg) = @_; | |||
| if (!defined($arg) || $arg eq "") { | |||
| reply("You'll have to give the oracle something to work with, " . $sender . ".", $network, $sender, $channel); | |||
| } elsif ($arg =~ m/\?$/) { | |||
| reply(oracle($arg) . "% yes.", $network, $sender, $channel); | |||
There was a problem hiding this comment.
Not too keen on the string in question. I'd prefer a full sentence, like the other reply.
There was a problem hiding this comment.
I grepped for }oracle in my irc logs, and it's actually pretty hard to come up with some sentence that fits all questions. (But That is X% true almost never fits if it was a question.)
Any ideas?
There was a problem hiding this comment.
I guess I was never too bothered by the oracle's reply to questions. Perhaps we could just use 'likely' instead of 'true' for questions?
Suggested change
| reply(oracle($arg) . "% yes.", $network, $sender, $channel); | |
| reply("That is " . oracle($arg) . "% likely.", $network, $sender, $channel); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions will now get a
X% yes.reply.